Quote:
|
In Reply to Parent Post by Atul Khandekar
Modifications to Red Style (Only)
1. FORUMHOME: Removed the attribte style="white-space: nowrap" from the DIV that lists current online users.
2. PostBit:Introduced an "hspace=5" attribute to the images in the right top corner of every post, to reduce the clutter (reputation,bad post & IP images)
3. Next I'm going to look at what's causing this patch at the right hand side of every post (see pic.)
|
I just wrote a 20 minute reply and - darn - was in another tab and I accidentially closed the tab with my reply. So, from scratch...
You shouldn't be modifying templates. You also should not modify style attributes like headinclude, phpinclude_start, or phpinclude_end. You should be modifying css attributes and style basics such as 'Sizes and Dimensions'.
If you modify the FORUMHOME template
in your style, for example, it will 'freeze' so any changes I make in English - the base style - will not flow down to your style.
Why does this matter? Let's say I change the English header template - which I do every day or two. If you change that template
in your style, any changes I make will not flow down to your style. So - your style (in this case) will keep the same 'ticker' as existed when you made your change. Changes I make in English will not flow down to your style so anyone using your style will see an outdated 'ticker'. Which is not good.
If I take advertising and put it in a column on the side and the column isn't in your style, then people can use your style to peruse the boards without having to look at the advertising. A nice thought for folks, but an advertiser won't appreciate it.
Some sites are set up so that 'paid' members (Contributors here - same thing) can use a style where the advertising column is gone. I am considering that option.
I'll be looking at styles very soon, but I really want to establish English first so that the 'basics' are what I want. For example, as I said above, in the near future I will be adding a column on one side which involves template mods (this site loads slowly, but see
http://www.vbulletintemplates.com/mo...ead.php?t=4904 and an example is at
http://www.makeuptalk.com/forums/ Another example is at
http://anzanime.net/ ). The column will be for advertising (including yours) and stuff. If you modify a template in either of your styles, as opposed to an 'attribute' such as colours or 'Sizes and Dimensions', then the changes I do will not flow down to the templates in your styles.
In addition, I'm not sure how far I'll go with 'hacks' (mods). Take a look at
http://www.vbulletin.org/forum/ - It's skinned and seriously hacked. I really like it, but it's a bit extreme for here, I think... The bottom line is most of this stuff is template hacks and I want to ensure any hacks I do flow down into your styles. If I do a 'hack' and it breaks one of your styles, let me know and we can look at the template together.
For right now, play away - but styles will be playing an important role in the future - like starting in early January, much moreso than in the past, so I want to make sure we're working together when it comes to any template changes. As you can see - templates are something we have to be together on before you change any.
With respect to the issue in post 9 in this thread, that's not a template change - it's a style 'Sizes and Dimensions' change which is OK to play with - just like css attributes.
Right now, I have the English style set to 'liquid'. The forum tables resize if you resize your browser window. They (vB) set the default to a fixed width in their new style, but they do have a 'liquid' style as a sub-style. I'm getting real used to styles and that's not a big change. I can easily make a fixed width style based upon English if someone wants one. Pre-Gamma was a 'liquid' style as English is now.
Atul, please spend some time in the 'English' style and let me know what failure modes you find - other than colour preferences. I think we might want to revert your styles and then you can redo the colours and such. I think you might find it easier - they changed table nesting and such. I thought I reverted all your styles and I know I failed (the red remained) so there is definitely stuff in conflict with the old pre-gamma style base.
And - do you want to keep 2 styles? And do you want to keep them nested as they are? It doesn't matter to me - just curious.